Repository navigation
Removed obsolete Extra-Content-Type header. - #3143
Merged
laurit merged 1 commit intoOct 23, 2026
Merged
Conversation
Refactored creating of log exporter for declarative config
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
robsunday
commented
Oct 23, 2026
| Set<String> propertyKeys = exporterConfigProperties.getPropertyKeys(); | ||
| if (propertyKeys.isEmpty()) { | ||
| DeclarativeConfigProperties otlpHttp = defaultOtlpHttpConfig(exporterConfigProperties); | ||
| OtlpHttpLogRecordExporterComponentProvider provider = |
Contributor
Author
There was a problem hiding this comment.
[for reviewer] Using OtlpHttpLogRecordExporterComponentProvider was shorter, but actually an awkward solution. I decided to replace it with use OtlpDeclarativeConfigUtil class instead. This is also more aligned with env-vars config approach.
robsunday
changed the title
laurit
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In review of PR 3135 codex detected that
Extra-Content-Typeheader is set for env-vars config, but not for declarative config in log exporter setup.Investigations proved that
Extra-Content-Typeis no longer in use and should be removed.